Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add Python utility for reading DMAP files #1059

Merged
merged 15 commits into from Sep 21, 2023
Merged

common: add Python utility for reading DMAP files #1059

merged 15 commits into from Sep 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2023

  • Moved python scripts to their own folder.
  • Python utility for reading DMAP files.
  • Example for reading DMAP file content.

@ghost ghost changed the title common: example for reading dmap files using python common: python example for reading dmap files Sep 18, 2023
@ghost ghost changed the title common: python example for reading dmap files common: Python example for reading DMAP files Sep 18, 2023
@cdcseacave
Copy link
Owner

great work, this is so nice, thank you

I do have two suggestions though:

  1. a lot of scripts start to accumulate, can you pls create a scripts/python folder and move all existing py scripts there, including yours
  2. pls break your new file in two, one that just reads the DMAP file and return the data dictionary, and a second one that shows how to use it; the reason is the example also imports the visualization library which is not needed to read DMAP if a user only want that

@ghost ghost changed the title common: Python example for reading DMAP files common: create Python utility for reading DMAP files Sep 18, 2023
@ghost ghost changed the title common: create Python utility for reading DMAP files common: add Python utility for reading DMAP files Sep 19, 2023
Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks perfect now, thank you!

@ghost ghost marked this pull request as draft September 20, 2023 05:39
@ghost ghost marked this pull request as ready for review September 20, 2023 16:57
@ghost
Copy link
Author

ghost commented Sep 20, 2023

Ready to merge.

@cdcseacave cdcseacave merged commit c1b1cc9 into cdcseacave:develop Sep 21, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant